[Gstreamer-bugs] [Bug 106448] Changed - [PATCH] vorbis plugin detection fix

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=106448

Changed by in7y118 at public.uni-hamburg.de.

--- shadow/106448	Tue Feb 18 14:57:51 2003
+++ shadow/106448.tmp.4369	Fri Feb 21 11:29:54 2003
@@ -27,6 +27,19 @@
 rhythmbox from cvs and metadate in nautilus properties tab.
 
 ------- Additional Comments From foser at gentoo.org  2003-02-18 14:57 -------
 Created an attachment (id=14421)
 ogg with id3 tag detection fix
 
+
+------- Additional Comments From in7y118 at public.uni-hamburg.de  2003-02-21 11:29 -------
+2 comments:
+
+1) This typefind misses the oligatory check "if (size < sizeof
+(gulong)) return NULL;" at the beginning.
+2) I believe this code is too general, because it scans the whole 
+buffer for the text "vorbis" which could easily be included in other 
+files. (iE an mp3 wih iDv2 Title "vorbis speech" or some such)
+
+The right way would be to write it the way that the IDv2 stuff at the 
+beginning of the file is skipped and you look exactly after that.
+I believe Mp3 typefinding already does this.