[Gstreamer-bugs] [Bug 106448] Changed - [PATCH] vorbis plugin detection fix

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=106448

Changed by foser at gentoo.org.

--- shadow/106448	Fri Feb 21 11:29:54 2003
+++ shadow/106448.tmp.7358	Fri Feb 21 13:17:48 2003
@@ -40,6 +40,17 @@
 buffer for the text "vorbis" which could easily be included in other 
 files. (iE an mp3 wih iDv2 Title "vorbis speech" or some such)
 
 The right way would be to write it the way that the IDv2 stuff at the 
 beginning of the file is skipped and you look exactly after that.
 I believe Mp3 typefinding already does this.
+
+------- Additional Comments From foser at gentoo.org  2003-02-21 13:17 -------
+1) That wasn't there in the first place..
+2) It scans vor the vorbis identification header which is
+'\0x01vorbis', i think that should be good enough. The initial check
+actually only checks if it is an ogg container and only checks for the
+string 'OggS' at the start, which is even more general.
+
+I don't think the id3 header is of a known length, so it might take
+more time than this trick. And what the mp3 typefinder does is of no
+relevance here.