[gstreamer-bugs] [Bug 361260] nuvdemux element

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=361260

  GStreamer | gst-plugins-bad | Ver: HEAD CVS


René Stadler changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mail at renestadler.de




------- Comment #3 from René Stadler  2006-10-10 21:35 UTC -------
Tips about the utility functions: gst_nuv_demux_getdwle is unneeded, just use
GST_READ_UINT32_LE (like you already do mostly, why are some places handled by
gst_nuv_demux_getdwle?).

GetDoubleLE is a bit awkward, better make use of the existing byte order
swapping macro for guint64 instead, like this:

#if G_BYTE_ORDER == G_BIG_ENDIAN
static inline gdouble
_gdouble_swap_le_be (gdouble d)
{
  union {
    guint64 i;
    gdouble d;
  } u;

  u.d = d;
  u.i = GUINT64_SWAP_LE_BE (u.i);
  return u.d;
}
#define READ_DOUBLE_FROM_LE(d) (_gdouble_swap_le_be(d))
#else /* G_BYTE_ORDER != G_BIG_ENDIAN
#define READ_DOUBLE_FROM_LE(d) (d)
#endif /* G_BYTE_ORDER != G_BIG_ENDIAN

(adapt it as needed)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email