[gstreamer-bugs] [Bug 361260] nuvdemux element

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=361260

  GStreamer | gst-plugins-bad | Ver: HEAD CVS





------- Comment #4 from René Stadler  2006-10-10 21:57 UTC -------
Instead of GST_WARNING, GST_ERROR, etc. use GST_OBJECT_WARNING,
GST_OBJECT_ERROR.

In gst_nuv_demux_chain:

  if (NULL == nuv->adapter) {
    GST_ERROR (_("pull expected! Chain func should not be called"));

GST_(OBJECT_)ERROR generates a debug message, no need for translation here. 
Better write nuv->adapter == NULL for readability.

In gst_nuv_demux_reset, all these

  if (nuv->h != NULL) {
    g_free (nuv->h);
    nuv->h = NULL;
  }

can be just written as

  g_free (nuv->h);
  nuv->h = NULL;

because g_free is just a no-op if the argument is NULL.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email