[gstreamer-bugs] [Bug 492114] Build issues on Windows/MSVC

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=492114

  GStreamer | gst-plugins-base | Ver: 0.10.14

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98250|none                        |committed
               Flag|                            |
  Attachment #98251|none                        |reviewed
               Flag|                            |
  Attachment #98252|0                           |1
        is obsolete|                            |
  Attachment #98253|none                        |committed
               Flag|                            |
  Attachment #98266|none                        |committed
               Flag|                            |
         AssignedTo|t.i.m at zen.co.uk             |gstreamer-
                   |                            |bugs at lists.sourceforge.net
             Status|ASSIGNED                    |RESOLVED
         OS/Version|All                         |Windows
         Resolution|                            |FIXED
            Summary|[PATCH] Build issues on     |Build issues on Windows/MSVC
                   |Windows/MSVC                |
   Target Milestone|HEAD                        |0.10.15




------- Comment #6 from Tim-Philipp Müller  2007-11-01 12:54 UTC -------
Thanks for the patches.

The ringbuffer warning fix I've done slightly differently (just return NULL).

The rtp header packing has already been fixed, as you said.

The config.h patch should really be against config.h.in :)

  2007-11-01  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Ole André Vadla Ravnås  <ole.andre.ravnas at tandberg.com>

        * gst-libs/gst/audio/gstringbuffer.c: (build_linear_format),
          (gst_ring_buffer_parse_caps):
          Return NULL instead of an enum that happens to be 0, fixes warning
          on MSVC (#492114).

        * gst-libs/gst/audio/gstringbuffer.h:
          No trailing commas in enum list (for gcc-2.9x).

        * gst/videotestsrc/videotestsrc.c: (random_char):
          Make information loss explicit instead of implicitly truncating to
          eight bits via the return value.  Fixes runtime error on MSVC when
          using the debug CRT (#492114).

        * win32/common/config.h.in:
          Fix a bunch of '#undef FOO bar', which MSVC doesn't like (#492114).

        * win32/common/libgstinterfaces.def:
        * win32/common/libgstrtp.def:
          Export a few more symbols (#492114).


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=492114.