[gstreamer-bugs] [Bug 518162] Patch for GStreamer to handle italic text starting with "/" with MicroDVD subs

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=518162

  GStreamer | gst-plugins-base | Ver: 0.10.17

Tomasz Sałaciński changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tsalacinski at gmail.com




------- Comment #1 from Tomasz Sałaciński  2008-02-23 02:04 UTC -------
And, additionally, mdvd parser, if won't find number of FPS in the file, like:

{1}{1}25.000

it will use 23,976 (it's hardcoded). IMHO the parser should use the movie's FPS
(for example Totem shows 25.000 FPS and it's working fine). Some movies are
encoded in 25.000 FPS and there is no information in the subtitle file about
this. Windows players handle this perfectly, though.

And, there is something wrong with this line:

  in_seg = gst_segment_clip (state->segment, GST_FORMAT_TIME,
      state->start_time, state->start_time + state->duration, &clip_start,
      &clip_stop);

Sometimes, after seeking, the subtitles are not shown, even if they are
supposed to be shown. GStreamer will show the next line and continue to show
subs properly then, it's only after seeking.

I discovered, that this can be fixed by changing this:

  if (in_seg) {
    state->start_time = clip_start;
    state->duration = clip_stop - clip_start;
  } else {
    return NULL;
  }

to this:

  if (in_seg) {
    state->start_time = clip_start;
    state->duration = clip_stop - clip_start;
  }

We are simply parsing subs even if (in_seq) shows that we don't have to.
Seeking forward works slightly slower, though, so that's not what we want (on
my 3ghz Celeron comp GStreamer is the fastest engine, this change slows it down
so it works like few Windows players). Haven't found a solution yet.

I think I'll rewrite this function from scratch, I've been creating a media
player based on GStreamer and I've created my own subtitle parser - with Pango
markup, and it was working great.

These two patches (fix for second patch, please?), and ability to read FPS not
from file but just from the movie, and GStreamer will finally handle MicroDVD
subtitles properly.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=518162.