[gstreamer-bugs] [Bug 611692] Add more warning flags

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Mar 7 06:38:39 PST 2010


https://bugzilla.gnome.org/show_bug.cgi?id=611692
  GStreamer | gstreamer (core) | git

--- Comment #30 from Benjamin Otte (Company) <otte at gnome.org> 2010-03-07 14:38:35 UTC ---
(In reply to comment #26)
> Review of attachment 155119 [details]:
> 
> I don't like all the extra "#ifdef GST_DISABLE_DEPRECATED" crap.
>
Yeah, the deprecated handling (in all of GNOME) is rather bad if you want to
increase the number of warning flags. I implemented the version that was both
sane and required the smallest diff. There's multiple ways to solve this (in
order of my preference):

1) Compile GStreamer without GST_DISABLE_DEPRECATED. That's bad because we
can't check we don't use deprecated symbols ourselves.

2) in gstfoo.c, do:
#undef GST_DISBALE_DPRECATED
#include "gstfoo.h
#define GST_DISABLE_DEPRECATED
That's similarly bad (it doesn't make sure the file doesn't use the deprecated
symbols) and it looks ugly, too.

3) The way in the patch, where I declare the function before implementing it.

4) Move all deprecated functions into gst_deprecated.c and #undef
GST_DISABLE_DEPRECATED in there. I didn't do that because it'd have blown up
the diffs. Note also that it might not work if the deprecated stuff can't be
moved to a different file due to relying on static functions used by
non-deprecated stuff.

5) Use G_GNUC_DEPRECATED instead of GST_DISABLE_DEPRECATED. This would also
allow deprecating typedefs and public struct members. I don't know how well
that method works when handling deprecated code though. And I don't know how
well it's integrated into the GNOME tools (like gtk-doc).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list