[gstreamer-bugs] [Bug 611692] Add more warning flags

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=611692
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #29 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-03-05 09:43:02 UTC ---
> I'm not impressed by all the casting that needs to be done to make signed and
> unsigned compares work with -Wsigned-compare.  IMO, this makes the code much
> more prone to errors.

I was surprised there wasn't more casting needed actually.

Something I've been wondering: is this guaranteed to work in ANSI C or
dependent on compiler whims:

  if ((guint64) ts == -1)
    ...

I was under the impression that you can't rely on compilers not just optimising
this away as 'comparison always false due to incompatible range', but have been
too lazy to find out for sure so far. If this is the case, then
-Wsigned-compare probably makes sense, no? (Even more so if current versions of
gcc do what we mean in this case).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.