[Bug 654379] webmux: make webmstream pass mkvalidator

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Jul 11 00:08:52 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=654379
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #191681|none                        |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2011-07-11 07:08:49 UTC ---
Review of attachment 191681:
 --> (https://bugzilla.gnome.org/review?bug=654379&attachment=191681)

::: gst/matroska/matroska-mux.h
@@ +88,3 @@
   /* EBML DocType. */
   const gchar    *doctype;
+  gboolean       is_webm;

Why do you add a new field instead of changing the doctype to an enum and
convert the enum to a string in the single place where doctype is used?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list