[Bug 654379] webmux: make webmstream pass mkvalidator

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=654379
  GStreamer | gst-plugins-good | git

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2011-07-11 07:12:22 UTC ---
Review of attachment 191681:
 --> (https://bugzilla.gnome.org/review?bug=654379&attachment=191681)

::: gst/matroska/matroska-mux.c
@@ +2694,3 @@
   if (collect_pad->track->type == GST_MATROSKA_TRACK_TYPE_VIDEO) {
     if (GST_BUFFER_FLAG_IS_SET (buf, GST_BUFFER_FLAG_DELTA_UNIT)) {
+      if (!mux->is_webm && (strcmp (collect_pad->track->codec_id,

Why only for the !webm case?

@@ +2708,3 @@
+  } else if (collect_pad->track->type == GST_MATROSKA_TRACK_TYPE_AUDIO &&
+      mux->is_webm)
+    flags = 0x80;

Isn't this setting the discardable flag? You probably meant to set the keyframe
flag

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.