[Bug 654572] Set but unused warning

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Jul 14 03:35:53 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=654572
  GStreamer | gst-plugins-bad | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bilboed at gmail.com

--- Comment #3 from Edward Hervey <bilboed at gmail.com> 2011-07-14 10:35:48 UTC ---
Then use #if 0 and not comments. The point is not to lose information/code
which is presently unused but would be potentially useful later on.

Also ... it would be good to dig in a bit deeper than "oh, variable unused,
let's remove it". There's a chance that it's also the indicator of a bug in the
code.

I would have removed all of those a year ago when I did the big clang analysis,
but didn't because I wasn't 100% sure they were *really* unused.

In case of doubt, I'd much prefer if you contacted the maintainers/authors of
those plugins to make sure those variables are really not needed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list