[Bug 654572] Set but unused warning

Thu Jul 14 13:25:59 PDT 2011

https://bugzilla.gnome.org/show_bug.cgi?id=654572
  GStreamer | gst-plugins-bad | git

David Schleef <ds> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from David Schleef <ds at schleef.org> 2011-07-14 20:25:55 UTC ---
I don't mind removing that pretty clearly looks unused.  The code can always be
retrieved from git.

Edward is correct that we prefer to use #ifdef unused or #if 0 for larger
chunks that are accidentally unused because of a bug -- removing the code
papers over the bug.

In any case, this is what code review is for.  If I don't approve of deleting a
chunk of code, I'll just remove it from the commit before pushing.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.