[Bug 687548] New: SPS/PPS NAL units not created correctly in h264parse if format is bytestream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=687548
  GStreamer | gst-plugins-bad | 1.0.2

           Summary: SPS/PPS NAL units not created correctly in h264parse
                    if format is bytestream
    Classification: Platform
           Product: GStreamer
           Version: 1.0.2
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: gimmeamilkbttf at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=228006)
 View: https://bugzilla.gnome.org/attachment.cgi?id=228006
 Review: https://bugzilla.gnome.org/review?bug=687548&attachment=228006

Fixes SPS/PPS generation for bytestream format

Looks to be introduced in commit 7f72b99426e8615cc16bff1c8157cd7d6efdba54

Attached patch corrects 2 things:
- don't rewind to the NAL length size in bytewriter if the format is bytestream
- put back the gst_byte_writer_put_buffer() call for PPS (presumably got
deleted accidentally)

ps. first-time caller so apologies if this isn't the preferred way of
reporting/submitting

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.