[Bug 687548] h264parse: SPS/PPS NAL units not created correctly if format is bytestream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=687548
  GStreamer | gst-plugins-bad | 1.0.2

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
            Summary|SPS/PPS NAL units not       |h264parse: SPS/PPS NAL
                   |created correctly in        |units not created correctly
                   |h264parse if format is      |if format is bytestream
                   |bytestream                  |
           Severity|normal                      |major

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-11-04 16:51:23 UTC ---
Thanks for the patch!

The preferred format is actually in "git format-patch" format, so including
author and commit message, but we can add that if needed.

I presume this fixes the issue you mentioned on the mailing list?

> The following pipeline (to turn .mp4 into .ts) works fine for me in
> GStreamer 0.10:
>  
>     gst-launch-0.10 filesrc location=/tmp/temp.mp4 ! qtdemux  !
>           h264parse !  mpegtsmux name=mux ! filesink location=/tmp/output.ts
> 
> But the same pipeline with GStreamer 1.0.2 produces an output.ts that VLC
> won't play. As far as I can see in the TS output, there don't seem to be any
> SPS/PPS startcodes (they are present in the output from 0.10).
> 
> The output from the h264parse element appears to be identical between the
> two versions.
> 
> I looked at the source for the latest mpegtsmux, and there is no longer any
> mention of SPS/PPS anywhere. In fact, a whole file mpegtsmux_h264.c seems to
> have disappeared.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.