[Bug 688707] rtsp-media: bus watch can outlive the rtsp-media object

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=688707
  GStreamer | gst-rtsp-server | git

--- Comment #1 from David Svensson Fors <davidsf at axis.com> 2012-11-20 08:28:50 UTC ---
Created an attachment (id=229448)
 View: https://bugzilla.gnome.org/attachment.cgi?id=229448
 Review: https://bugzilla.gnome.org/review?bug=688707&attachment=229448

Remove bus watch before finalizing

A suggested fix is attached:

* A GDestroyNotify function is set for the bus watch in gst_rtsp_media_prepare.
* An extra media ref is added for the bus watch. This extra ref is unreffed by
the GDestroyNotify function.
* gst_rtsp_media_unprepare destroys the source so the bus watch is removed.
* GstRTSPClient, which calls gst_rtsp_media_prepare, also calls
gst_rtsp_media_unprepare before unreffing the media.

This way, the bus watch will be removed before the media is finalized.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.