[Bug 688707] rtsp-media: bus watch can outlive the rtsp-media object

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=688707
  GStreamer | gst-rtsp-server | git

Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |wim.taymans at gmail.com
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.0.x

--- Comment #2 from Wim Taymans <wim.taymans at gmail.com> 2012-11-20 08:47:32 UTC ---
I changed it so that the source is removed in finish_unprepare in the case of
clean shutdown.

commit 989f004e24e6e6e8d8a0a041849d9ce593403666
Author: Wim Taymans <wim.taymans at collabora.co.uk>
Date:   Tue Nov 20 09:42:51 2012 +0100

    media: unref source in finish_unprepare

    The source is created in prepare, unref it in finish_unprepare.

    See https://bugzilla.gnome.org/show_bug.cgi?id=688707

commit 01973c924d3fc850b812a7aaf1b2691a8fd01ae0
Author: David Svensson Fors <davidsf at axis.com>
Date:   Mon Nov 19 15:47:08 2012 +0100

    rtsp-media: remove bus watch before finalizing

    * A GDestroyNotify function is set for the bus watch in
gst_rtsp_media_prepare.
    * An extra media ref is added for the bus watch. This extra ref is unreffed
by
    the GDestroyNotify function.
    * gst_rtsp_media_unprepare destroys the source so the bus watch is removed.
    * GstRTSPClient, which calls gst_rtsp_media_prepare, also calls
    gst_rtsp_media_unprepare before unreffing the media.

    This way, the bus watch will be removed before the media is finalized.

    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=688707

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.