[Bug 719938] rtpbin: allow dynamic RTP/RTCP encoders and decoders

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=719938
  GStreamer | gst-plugins-good | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263629|none                        |needs-work
             status|                            |

--- Comment #5 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-12-06 02:25:25 UTC ---
Review of attachment 263629:
 --> (https://bugzilla.gnome.org/review?bug=719938&attachment=263629)

Apart for the two little details, I think we're pretty much there. Wim?

::: gst/rtpmanager/gstrtpbin.c
@@ +2517,3 @@
+      if (!gst_bin_add (GST_BIN_CAST (session->bin), encoder))
+        goto add_failed;
+      gst_element_sync_state_with_parent (encoder);

Would probably make sense to check this return value also maybe ?

@@ +2849,3 @@
+    GST_DEBUG_OBJECT (rtpbin, "linking RTP decoder");
+    decsink = gst_element_get_static_pad (decoder, "rtp_sink");
+    decsrc = gst_element_get_static_pad (decoder, "rtp_src");

Should check if the pads exist.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.