[Bug 719938] rtpbin: allow dynamic RTP/RTCP encoders and decoders

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=719938
  GStreamer | gst-plugins-good | git

--- Comment #6 from Aleix Conchillo Flaqué <aleix at oblong.com> 2013-12-06 07:10:58 UTC ---
(In reply to comment #5)
> Review of attachment 263629 [details]:
> 

Thanks for the review again.

> Apart for the two little details, I think we're pretty much there. Wim?
> 
> ::: gst/rtpmanager/gstrtpbin.c
> @@ +2517,3 @@
> +      if (!gst_bin_add (GST_BIN_CAST (session->bin), encoder))
> +        goto add_failed;
> +      gst_element_sync_state_with_parent (encoder);
> 
> Would probably make sense to check this return value also maybe ?
> 

I'll check the return value but only report a warning.

> @@ +2849,3 @@
> +    GST_DEBUG_OBJECT (rtpbin, "linking RTP decoder");
> +    decsink = gst_element_get_static_pad (decoder, "rtp_sink");
> +    decsrc = gst_element_get_static_pad (decoder, "rtp_src");
> 
> Should check if the pads exist.

OK.

I'll send a patch tomorrow.

If everyone else is fine with this I'll add a bit of documentation.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.