[Bug 684237] videomixer: Caps negotiation does not always work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=684237
  GStreamer | gst-plugins-good | git

--- Comment #54 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-20 12:17:50 UTC ---
(In reply to comment #47)
> Review of attachment 244686 [details]:
> 
> One small comment about this one, but I think it can still me merged.
> 
> ::: gst/videomixer/videomixer2.c
> @@ +963,3 @@
>      GST_DEBUG_OBJECT (mix, "pending flush stop");
>      gst_pad_push_event (mix->srcpad, gst_event_new_flush_stop (TRUE));
> +    mix->flush_stop_pending = FALSE;
> 
> My understanding is that this case does not exist, unless all sources forget to
> send flush-stop and starts sending data. Is that correct ?

If anything sends data after flush-start and before flush-stop, the pads will
reject the data. So that can never happen

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.