[Bug 684237] videomixer: Caps negotiation does not always work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=684237
  GStreamer | gst-plugins-good | git

--- Comment #55 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-20 12:20:06 UTC ---
(In reply to comment #50)
> Review of attachment 244689 [details]:
> 
> I think this one will need some thought, and maybe second opinion. What I had
> in mind for when I'd give a second round to this, would have been to keep the
> filter caps passed durring  caps query, and only send reconfigure if the
> selected caps are part of the filtered caps. This way, only element with buggy
> negotiation could loop.
> 
> ::: gst/videomixer/videomixer2.c
> @@ +322,3 @@
> +          "current caps are %" GST_PTR_FORMAT, caps, mix->current_caps);
> +      gst_pad_push_event (pad, gst_event_new_reconfigure ());
> +      return FALSE;
> 
> I'm worried about this one because if an element don't call accept_caps()
> (which is optional iirc) because it only support a single format, it may keep
> sending and getting reconfigure again and again.

Why would that ever loop? Upstream would check if it can negotiate something
new here, if it can't (or ignores the reconfigure event), at latest stuff will
error out when buffers are pushed (because then an incompatible caps event
would be forwarded, and core checks with accept-caps if caps are supported
before forwarding that event).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.