[Bug 698894] mulawdec: Change base class to GstAudioDecoder

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue May 21 04:41:26 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=698894
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244908|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-21 11:41:18 UTC ---
Review of attachment 244908:
 --> (https://bugzilla.gnome.org/review?bug=698894&attachment=244908)

::: gst/law/mulaw-decode.c
@@ +94,1 @@
 gst_mulawdec_handle_frame (GstAudioDecoder * dec, GstBuffer * buffer)

It should return a GstFlowReturn (same for the encoder). So don't return things
like TRUE and FALSE (it already returns FALSE in an error case currently)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list