[Bug 698894] mulawdec: Change base class to GstAudioDecoder

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue May 21 04:47:11 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=698894
  GStreamer | gst-plugins-good | unspecified

--- Comment #7 from Alexander Schrab <alexas at axis.com> 2013-05-21 11:47:06 UTC ---
You are of course right. I was tricked by the return FALSE and the fact that
many of the other functions do have gboolean as signature... I'll fix

(In reply to comment #6)
> Review of attachment 244908 [details]:
> 
> ::: gst/law/mulaw-decode.c
> @@ +94,1 @@
>  gst_mulawdec_handle_frame (GstAudioDecoder * dec, GstBuffer * buffer)
> 
> It should return a GstFlowReturn (same for the encoder). So don't return things
> like TRUE and FALSE (it already returns FALSE in an error case currently)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list