[Bug 700749] gstrtph264pay/depay: Add framerate and optional framesize SDP attribute to payloaded caps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=700749
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245124|none                        |needs-work
             status|                            |

--- Comment #24 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-23 13:51:57 UTC ---
Review of attachment 245124:
 --> (https://bugzilla.gnome.org/review?bug=700749&attachment=245124)

::: gst/rtp/gstrtph264depay.c
@@ +656,3 @@
+  if (gst_structure_get_fraction (structure, "framerate", &num, &denom) &&
+      (num < 0 || denom <= 0)) {
+    goto invalid_framerate;

This *requires* a framerate now. If there's none it will error out. It should
only use a framerate if it is available in the caps, otherwise just work as
before

::: gst/rtp/gstrtph264pay.c
@@ +473,3 @@
+  if (gst_structure_get_fraction (str, "framerate", &num, &denom) &&
+      (num < 0 || denom <= 0)) {
+    goto invalid_framerate;

Same here, it should work without a framerate too

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.