[Bug 700749] gstrtph264pay/depay: Add framerate and optional framesize SDP attribute to payloaded caps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=700749
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245123|none                        |needs-work
             status|                            |

--- Comment #25 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-23 13:53:25 UTC ---
Review of attachment 245123:
 --> (https://bugzilla.gnome.org/review?bug=700749&attachment=245123)

::: gst/rtp/gstrtph264depay.c
@@ +640,3 @@
+  }
+  if (gst_structure_get_int (structure, "height", &height) && height <= 0) {
+    goto invalid_dimension;

Same here, should work without width/heiight specified too because of
compatibility reasons

::: gst/rtp/gstrtph264pay.c
@@ +463,3 @@
+  }
+  if (!gst_structure_get_int (str, "width", &width) || width <= 0) {
+    goto invalid_dimension;

Here it's fine to require width/height to be present

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.