[Bug 701177] New: Improve git-update.sh status message

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed May 29 01:27:59 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=701177
  GStreamer | gst-devtools | git

           Summary: Improve git-update.sh status message
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: Normal
         Component: gst-devtools
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: krzysztof.konopko at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=245525)
 View: https://bugzilla.gnome.org/attachment.cgi?id=245525
 Review: https://bugzilla.gnome.org/review?bug=701177&attachment=245525

Proposed patch

By default when the script is about to exit (normally or due to an error), it
checks whether $ERROR_LOG file exists.  If the log file exists, the script
prints a "Failures: " message prefix and dumps the log file to the output.

Apparently the log file is always created and if the update/build is
successful, the script finishes with a bit misleading "Failures: " message.

An improvement provided with this change lets the log file to be created as
needed, i.e. if there's an error message to be printed.  If the file doesn't
exists, the script prints a "Update done" message which clearly indicates
success.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list