[Bug 701177] scripts: improve git-update.sh status message

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701177
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
          Component|gst-devtools                |gstreamer (core)
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.1.1
            Summary|Improve git-update.sh       |scripts: improve
                   |status message              |git-update.sh status
                   |                            |message

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-05-30 22:42:13 UTC ---
Thanks for the patch! Pushed into master:


commit 527423fcd9a5b74b8bc3dfbae75871b9c0f87f7c
Author: Krzysztof Konopko <krzysztof.konopko at gmail.com>
Date:   Tue May 28 23:34:54 2013 +0100

    scripts: improve git-update.sh status message

    By default when the script is about to exit (normally or due to an error),
    it checks whether $ERROR_LOG file exists.  If the log file exists, the
    script prints a "Failures: " message prefix and dumps the log file to the
    output.

    Apparently the log file is always created and if the update/build is
    successful, the script finishes with a bit misleading "Failures: " message.

    An improvement provided with this change lets the log file to be created as
    needed, i.e. if there's an error message to be printed.  If the file
    doesn't exists, the script prints a "Update done" message which clearly
    indicates success.

    https://bugzilla.gnome.org/show_bug.cgi?id=701177

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.