[Bug 705991] Adding support for DASH common encryption to qtdemux and dashdemux

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705991
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258525|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-01 14:32:23 UTC ---
Review of attachment 258525:
 --> (https://bugzilla.gnome.org/review?bug=705991&attachment=258525)

Please add a pkg-config file in the pkgconfig directory

::: gst-libs/gst/cenc/Makefile.am
@@ +45,3 @@
+        -I$(top_srcdir)/gst-libs \
+        --add-include-path=`PKG_CONFIG_PATH="$(GST_PKG_CONFIG_PATH)"
$(PKG_CONFIG) --variable=girdir gstreamer- at GST_API_VERSION@` \
+        --add-include-path=`PKG_CONFIG_PATH="$(GST_PKG_CONFIG_PATH)"
$(PKG_CONFIG) --variable=girdir gstreamer-base- at GST_API_VERSION@` \

You don't actually need base

@@ +51,3 @@
+        --libtool="$(top_builddir)/libtool" \
+        --pkg gstreamer- at GST_API_VERSION@ \
+        --pkg gstreamer-base- at GST_API_VERSION@ \

Or here

@@ +73,3 @@
+        --includedir=$(builddir) \
+        --includedir=`PKG_CONFIG_PATH="$(GST_PKG_CONFIG_PATH)" $(PKG_CONFIG)
--variable=girdir gstreamer- at GST_API_VERSION@` \
+        --includedir=`PKG_CONFIG_PATH="$(GST_PKG_CONFIG_PATH)" $(PKG_CONFIG)
--variable=girdir gstreamer-base- at GST_API_VERSION@` \

Or here

::: gst-libs/gst/cenc/cenc.h
@@ +28,3 @@
+typedef struct _CencSubsampleInfo CencSubsampleInfo;
+typedef struct _CencSampleCryptoInfo CencSampleCryptoInfo;
+typedef struct _CencSampleProperties CencSampleProperties;

These should all be in the Gst namespace

@@ +37,3 @@
+ * Holds information about a subsample of a cenc-protected sample.
+ */
+struct _CencSubsampleInfo

SubSample maybe?

@@ +57,3 @@
+  GBytes *iv;
+  guint16 n_subsamples;
+  GArray *subsample_info;

These should probably all get boxed types and ref/unref functions at least.
Maybe make them miniobjects? Also some padding in the structs might be sensible
:)

::: gst-libs/gst/cenc/gstcencmeta.c
@@ +16,3 @@
+ * Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */

Please add documentation here what this is all about and how it is used in
which use cases

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.