[Bug 711230] rtspsrc: allow setting certificate validation flags

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711230
  GStreamer | gst-plugins-good | 1.2.0

--- Comment #3 from Aleix Conchillo Flaqué <aleix at oblong.com> 2013-11-01 14:33:35 UTC ---
(In reply to comment #2)
> Review of attachment 258690 [details]:
> 
> Generally looks good
> 
> ::: gst/rtsp/gstrtspsrc.c
> @@ +187,3 @@
>  #define DEFAULT_NTP_SYNC         FALSE
>  #define DEFAULT_USE_PIPELINE_CLOCK      FALSE
> +#define DEFAULT_TLS_VALIDATION_FLAGS G_TLS_CERTIFICATE_VALIDATE_ALL
> 
> Isn't the default to validate nothing currently? Changing the default could
> break things
> 

The default in g_socket_client is G_TLS_CERTIFICATE_VALIDATE_ALL. Actually,
this is why I had to add this.

https://developer.gnome.org/gio/2.32/GSocketClient.html#GSocketClient--tls-validation-flags

I'm using 2.38, but it's the same.

> @@ +591,3 @@
> +   * certificate.
> +   *
> +   * Since: 1.2.1
> 
> Since: 1.4.0 probably

I can send a new patch for this, if you want.

Oh, and thanks for the two reviews!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.