[Bug 703518] Qt5/QtQuick 2.0 video element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703518
  GStreamer | qt-gstreamer | unspecified

--- Comment #21 from Benjamin Federau <benjamin.federau at basyskom.com> 2013-10-11 15:58:18 UTC ---
(In reply to comment #16)
> Review of attachment 248290 [details]:
> 
> I don't like this patch in general.
> 
> 1) As I have said, I would prefer VideoNode* inside qtvideosink.

Feel free to shift it to the qtvideosink. When I started the implementation I
was not sure where to place my additions, so I decided to put it in the
QtGStreamerUI part. ;)

> 2) I'd rather not expose those Abstract* classes. AbstractVideoSurface makes
> sense maybe, but since we can't make it a superclass of GraphicsVideoSurface
> (to preserve ABI), it's useless.

I introduced this AbstractVideoSurface class because in my first implementation
I also had a PaintedVideoSurface for a PaintedVideoItem
(QQuickPaintedItem) QML element which uses the QPainter API. But I did not
include it here. By using only the QuickVideoSurface this abstraction is not
need.

> 3) There is a lot of commented out code and code with "still needed?" comments
> that should not be there.

Yes there are some leftovers which needs to removed ...

> 4) What is the purpose of VideoNode_Generic?

I created the VideoNode_Generic to render an (initial) transparent texture
before the video playback is started. Because without the first video frame I
was not able to determine the video format (RGB, YUV).
If you have a solution to render the initial node with one of the two other
VideoNode_* class you can remove this class.

> 
> ::: qt-gstreamer-orig/src/QGst/Ui/quickviewvideosurface.h
> @@ +62,3 @@
> +     * Helper - returns true if the given orientation has the same aspect as
> the default (e.g. 180*n)
> +     */
> +    inline bool isDefaultAspect(int o) {
> 
> These inline methods could be in the .cpp

Some leftovers from the QtMultimedia inspired code parts that I have used.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.