[Bug 703518] Qt5/QtQuick 2.0 video element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703518
  GStreamer | qt-gstreamer | unspecified

--- Comment #22 from Benjamin Federau <benjamin.federau at basyskom.com> 2013-10-11 16:12:29 UTC ---
(In reply to comment #17)
> Review of attachment 248291 [details]:
> 
> The qml2 plugin export mechanism confuses me a bit, there are a lot of names
> involved... We have QtGStreamerQuick2.json,
> org.freedesktop.gstreamer.Qt5GStreamerQuick2-0.10, QtGStreamerQuick2 in the
> qmldir file, and in the example (later patch) it is loaded with "import
> QtGStreamer.Quick2 0.10". That is just confusing. I'd expect one name
> everywhere (Qt5GStreamerQuick2 ?).

Yes one name makes sense. 
When I added my QtQuick2 plugin I created a folder for the QtQuick1 and a
folder for the QtQuick2 plugin. This is why it results in the two imports in
the qmlplayer examples.

"import QtGStreamer.Quick1 0.10" (qmlplayer)
"import QtGStreamer.Quick2 0.10" (qmlplayer2)


> 
> Also note that this patch should also modify the UNINSTALLED_IMPORTS_DIR in the
> qmlplayer example, as the directory is changing with this patch.
> 
> ::: qt-gstreamer-orig/src/qml/quick2/CMakeLists.txt
> @@ +13,3 @@
> +  # On windows with gcc, cmake calls the binary libFOO.dll, but the Qt plugin
> loader
> +  # does not remove the lib prefix when searching for .dlls, unlike what
> happens on unix
> +  file(WRITE ${CMAKE_CURRENT_BINARY_DIR}/qmldir "plugin libQtGStreamerQuick2")
> 

> Apparently qmldir nowdays also requires a "module Foo" statement, otherwise it
> shows a warning.

Yes should be added then.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.