[Bug 706054] move GstEGLImageBufferPool and allocator from eglglessink to gstegl lib

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=706054
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254062|none                        |needs-work
             status|                            |

--- Comment #22 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-09-04 15:11:03 UTC ---
Review of attachment 254062:
 --> (https://bugzilla.gnome.org/review?bug=706054&attachment=254062)

::: gst-libs/gst/egl/egl.c
@@ +393,3 @@
+  GstEGLImageBufferPoolSendBlockingAllocate send_blocking_allocate_func;
+  gpointer send_blocking_allocate_data;
+  GDestroyNotify send_blocking_allocate_destroy;

and most of this has to be moved into a private struct

::: gst-libs/gst/egl/egl.h
@@ +72,3 @@

+/* EGLImage buffer pool */
+typedef struct _GstEGLImageBufferPool GstEGLImageBufferPool;

This struct and the class struct must be public to make g-i and gtk-doc happy

@@ +75,3 @@
+typedef GstBuffer *(*GstEGLImageBufferPoolSendBlockingAllocate) (GstBufferPool
*
+    pool, gpointer data);
+#define GST_EGL_IMAGE_BUFFER_POOL(p) ((GstEGLImageBufferPool*)(p))

G_TYPE_CHECK_INSTANCE_CAST() or whatever the GLib macro for this was :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.