[Bug 704769] Make libav codecs handle gracefully renegotiation.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704769
  GStreamer | gst-libav | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254082|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-09-04 15:15:00 UTC ---
Review of attachment 254082:
 --> (https://bugzilla.gnome.org/review?bug=704769&attachment=254082)

::: ext/libav/gstavviddec.c
@@ +259,3 @@
   ffmpegdec->debug_mv = DEFAULT_DEBUG_MV;
   ffmpegdec->max_threads = DEFAULT_MAX_THREADS;
+  ffmpegdec->decided_allocation = FALSE;

This will make the element not reusable. At least in GstVideoDecoder::start
this should be set to FALSE too, or maybe even in flush

@@ +1531,3 @@
   /* we can only enable the alignment if downstream supports the
    * videometa api */
+  if (!ffmpegdec->decided_allocation && have_alignment && have_videometa) {

Note that this will cause gst-libav to not work zerocopy anymore. Maybe it
would be better to just keep the old allocation configuration? It is guaranteed
that it will still work and maybe it is more optimal.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.