[Bug 707530] [qtdemux] Handle segments correctly in push mode seeks

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=707530
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254149|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-09-05 12:05:08 UTC ---
Review of attachment 254149:
 --> (https://bugzilla.gnome.org/review?bug=707530&attachment=254149)

::: libs/gst/base/gstbasesrc.c
@@ +821,3 @@
   /* Mark pending segment. Will be sent before next data */
   src->priv->segment_pending = TRUE;
+  src->priv->segment_seqnum = 0;

I think you should initialize this with gst_seqnum_next() and also call that in
::start()

@@ +2678,3 @@
+    GstEvent *seg_event = gst_event_new_segment (&src->segment);
+
+    if (src->priv->segment_seqnum) {

And here just always set the seqnum

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.