[Bug 707530] [qtdemux] Handle segments correctly in push mode seeks
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Sep 5 05:08:39 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=707530
GStreamer | gst-plugins-good | git
Sebastian Dröge (slomo) <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #254150|none |accepted-commit_now
status| |
--- Comment #5 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-09-05 12:08:36 UTC ---
Review of attachment 254150:
--> (https://bugzilla.gnome.org/review?bug=707530&attachment=254150)
Looks sensible but:
::: gst/isomp4/qtdemux.c
@@ +1907,3 @@
+ GST_DEBUG_OBJECT (demux, "Stored seek seqnum: %u, received segment "
+ "seqnum %u", demux->push_seek_seqnum, seqnum);
+ if (seqnum == demux->push_seek_seqnum) {
Instead of comparing the seqnum it should already be enough just compare the
start position
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list