[Bug 707530] [qtdemux] Handle segments correctly in push mode seeks

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=707530
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254151|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-09-05 12:12:33 UTC ---
Review of attachment 254151:
 --> (https://bugzilla.gnome.org/review?bug=707530&attachment=254151)

::: gst/isomp4/qtdemux.c
@@ +4923,3 @@
+          /* check for segment end */
+          if (G_UNLIKELY (demux->segment.stop != -1
+                  && demux->segment.stop <= pts && stream->on_keyframe)) {

Why the on_keyframe here? It should do that always, independent of the seek
type

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.