[Bug 740987] Fixes to osxaudiosrc and osxaudiosink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740987
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291923|none                        |reviewed
             status|                            |

--- Comment #15 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-03 10:46:35 UTC ---
Review of attachment 291923:
 --> (https://bugzilla.gnome.org/review?bug=740987&attachment=291923)

::: sys/osxaudio/gstosxaudiosink.c
@@ +310,3 @@
 {
   GstOsxAudioSink *sink = GST_OSX_AUDIO_SINK (base);
+  GstAudioRingBuffer *buf = GST_AUDIO_BASE_SINK (sink)->ringbuffer;

This might also need to be protected by a mutex, not sure

@@ +324,1 @@
   if (sink->cached_caps) {

Probing is protected by the mutex... but sink->cached_caps not?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.