[Bug 740987] Fixes to osxaudiosrc and osxaudiosink

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Dec 3 02:54:18 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=740987
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291924|none                        |needs-work
             status|                            |

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-03 10:54:14 UTC ---
Review of attachment 291924:
 --> (https://bugzilla.gnome.org/review?bug=740987&attachment=291924)

::: sys/osxaudio/gstosxaudiosink.c
@@ +276,3 @@
+      ringbuffer =
+          GST_OSX_AUDIO_RING_BUFFER (GST_AUDIO_BASE_SINK
(osxsink)->ringbuffer);
+      osxsink->device_id = ringbuffer->core_audio->device_id;

g_object_notify() for the property maybe

::: sys/osxaudio/gstosxaudiosrc.c
@@ +233,3 @@
+      ringbuffer =
+          GST_OSX_AUDIO_RING_BUFFER (GST_AUDIO_BASE_SRC (osxsrc)->ringbuffer);
+      osxsrc->device_id = ringbuffer->core_audio->device_id;

g_object_notify() too

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list