[Bug 547661] vcd: port to 1.0

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=547661
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291951|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-04 15:47:44 UTC ---
Review of attachment 291951:
 --> (https://bugzilla.gnome.org/review?bug=547661&attachment=291951)

Looks almost ready, good work :)

::: sys/vcd/vcdsrc.c
@@ +356,3 @@
+error_mapped:
+  gst_buffer_unmap (outbuf, &map_info);
+error_unmapped:

You should also unref outbuf here

@@ +476,1 @@
 gst_vcdsrc_uri_get_uri (GstURIHandler * handler)

This change probably means that you need to g_strdup() the URI you return

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.