[Bug 547661] vcd: port to 1.0

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Dec 4 08:35:18 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=547661
  GStreamer | gst-plugins-bad | git

--- Comment #8 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> 2014-12-04 16:35:15 UTC ---
Thanks for taking a look Sebastian

(In reply to comment #7)
> Review of attachment 291951 [details]:
> [...]
> ::: sys/vcd/vcdsrc.c
> @@ +356,3 @@
> +error_mapped:
> +  gst_buffer_unmap (outbuf, &map_info);
> +error_unmapped:
> 
> You should also unref outbuf here

Done

> @@ +476,1 @@
>  gst_vcdsrc_uri_get_uri (GstURIHandler * handler)
> 
> This change probably means that you need to g_strdup() the URI you return

Not sure I understand. I'm already duping that return

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the gstreamer-bugs mailing list