[Bug 739992] h264parse: expose compatible profiles to downstream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739992
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291970|none                        |reviewed
             status|                            |

--- Comment #26 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-04 17:29:06 UTC ---
Review of attachment 291970:
 --> (https://bugzilla.gnome.org/review?bug=739992&attachment=291970)

Looks good but (apart from typo in commit message: realx -> relax)

::: gst/videoparsers/gsth264parse.c
@@ +1234,3 @@
+        profiles = profile_array;
+      } else {
+        static const gchar *profile_array[] = { "extended", NULL };

Isn't unconstrained baseline compatible with main, high, and basically
everything other than constrained-baseline?

@@ +1248,3 @@
+      if (sps->constraint_set1_flag) {
+        static const gchar *profile_array[] =
+            { "main", "high-10", "high-4:2:2", "high-4:4:4", NULL };

Constrained high is compatible with main?

@@ +1259,3 @@
+      if (sps->constraint_set1_flag) {
+        static const gchar *profile_array[] =
+            { "main", "high", "high-4:2:2", "high-4:4:4", NULL };

And constrained High10 with main and non-10 high?

@@ +1278,3 @@
+      if (sps->constraint_set1_flag) {
+        static const gchar *profile_array[] =
+            { "main", "high", "high-10", "high-4:4:4", NULL };

And same here

@@ +1295,3 @@
+        static const gchar *profile_array[] =
+            { "main", "high", "high-10", "high-4:2:2", NULL };
+        profiles = profile_array;

And here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.