[Bug 739992] h264parse: expose compatible profiles to downstream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739992
  GStreamer | gst-plugins-bad | git

--- Comment #27 from sreerenj <bsreerenj at gmail.com> 2014-12-05 03:31:39 UTC ---
(In reply to comment #26)
> Review of attachment 291970 [details]:
> 
> Looks good but (apart from typo in commit message: realx -> relax)
> 
> ::: gst/videoparsers/gsth264parse.c
> @@ +1234,3 @@
> +        profiles = profile_array;
> +      } else {
> +        static const gchar *profile_array[] = { "extended", NULL };
> 
> Isn't unconstrained baseline compatible with main, high, and basically
> everything other than constrained-baseline?

NO,,constrained_baseline < baseline < extended_profile and
constrained_baseline < main < high
but main & high are not always compatible with baseline and extended :)

> @@ +1248,3 @@
> +      if (sps->constraint_set1_flag) {
> +        static const gchar *profile_array[] =
> +            { "main", "high-10", "high-4:2:2", "high-4:4:4", NULL };
> 
> Constrained high is compatible with main?

The csf1 is checked for the compatibility with main profile :)

We are not handling constrained-high and progressive-high separately...
even in gst-plugins-base/gst-libs/gst/pbutils/codec-utils.c,,thats the reason i
omitted those..but yes, can add those later on...may be first a patch to
codec-utils..

> 
> @@ +1259,3 @@
> +      if (sps->constraint_set1_flag) {
> +        static const gchar *profile_array[] =
> +            { "main", "high", "high-4:2:2", "high-4:4:4", NULL };
> 
> And constrained High10 with main and non-10 high?

There is no constrained-high10 profile !!
The constraint_set1_flag has been checked for main profile..which means csf1 ==
true, it is main profile compatible, which means compatible with high,
high-4:2:2 etc....

> @@ +1278,3 @@
> +      if (sps->constraint_set1_flag) {
> +        static const gchar *profile_array[] =
> +            { "main", "high", "high-10", "high-4:4:4", NULL };
> 
> And same here
>
same as above !
> @@ +1295,3 @@
> +        static const gchar *profile_array[] =
> +            { "main", "high", "high-10", "high-4:2:2", NULL };
> +        profiles = profile_array;
> 
> And here

same as above !

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.