[Bug 724893] playsinkconvertbin: improve gst_play_sink_convert_bin_getcaps return

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Feb 22 06:58:16 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=724893
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #269922|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-02-22 15:19:07 UTC ---
(From update of attachment 269922)
This is not 100% correct yet. "converter_caps" might be bigger than the filter
caps.

What you need to do is to return
intersect_first(filter, peer_caps) + intersect_first(filter, converter_caps)

Also I think the intersection part should just be moved from the bottom inside
the if (otherpad) branch and its else branch instead of adding this
"apply_filter" variable.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list