[Bug 724893] playsinkconvertbin: improve gst_play_sink_convert_bin_getcaps return

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Feb 22 06:59:26 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=724893
  GStreamer | gst-plugins-base | git

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-02-22 15:20:19 UTC ---
(In reply to comment #2)
> (From update of attachment 269922 [details])
> This is not 100% correct yet. "converter_caps" might be bigger than the filter
> caps.
> 
> What you need to do is to return
> intersect_first(filter, peer_caps) + intersect_first(filter, converter_caps)

Nevermind, ignore that part. It's correct as is, the peer_caps are already
filtered.

But please make the code a bit clearer by moving the filtering inside the
if/else blocks.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list