[Bug 733545] GL element leaks FBO when caps changed dynamically

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733545
  GStreamer | gst-plugins-bad | 1.4.0

--- Comment #4 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-07-23 03:19:10 UTC ---
Review of attachment 281446:
 --> (https://bugzilla.gnome.org/review?bug=733545&attachment=281446)

I'll leave it to Matthew on final review, I just have one small comment. Thanks
for taking the time tracking this.

::: gst-libs/gst/gl/gstglfilter.c
@@ +1105,3 @@
+    gst_gl_context_del_texture (filter->context, &filter->out_tex_id);
+    filter->out_tex_id = 0;
+  }

Just a nithpick, style would e better if you first free the resources, and then
start creating them, would also keep it clean in case one of the creation
failed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.