[Bug 733545] GL element leaks FBO when caps changed dynamically

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733545
  GStreamer | gst-plugins-bad | 1.4.0

Matthew Waters <ystreet00> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #281446|none                        |reviewed
             status|                            |

--- Comment #5 from Matthew Waters <ystreet00 at gmail.com> 2014-07-23 08:05:26 UTC ---
Review of attachment 281446:
 --> (https://bugzilla.gnome.org/review?bug=733545&attachment=281446)

Looks good.  Just some formatting nitpicks on top of Nicolas' comment.

Thanks for looking at this.

::: gst-libs/gst/gl/gstglfilter.c
@@ +280,3 @@
+    }
+
+

Spurious new line.

@@ +1083,3 @@
   out_height = GST_VIDEO_INFO_HEIGHT (&filter->out_info);

+  if (filter->fbo != 0) {

Any particular reason why the sudden use of != 0 ? :)

@@ +1093,3 @@
     goto context_error;

+

Spurious new line

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.