[Bug 733545] GL element leaks FBO when caps changed dynamically

Wed Jul 23 07:20:20 PDT 2014

https://bugzilla.gnome.org/show_bug.cgi?id=733545
  GStreamer | gst-plugins-bad | 1.4.0

comicfans44 <comicfans44> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #281446|0                           |1
        is obsolete|                            |

--- Comment #6 from comicfans44 <comicfans44 at gmail.com> 2014-07-23 14:20:14 UTC ---
Created an attachment (id=281479)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=281479)
improved patch v2 based on review suggestion.

(In reply to comment #5)
> Review of attachment 281446 [details]:
> 
> Looks good.  Just some formatting nitpicks on top of Nicolas' comment.
Thanks for reviewing, a improved patch with Nicolas' suggestion, release
FBO/texture before creating new ones ,this should also avoid leaks when new FBO 
creation failed. 

also cleaned != 0 code. I just quickly copied code from reset function to test
if
this worked, without re-check the style .sorry for that :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.