[Bug 721950] assrender: handle video/x-raw(ANY) if downstream supports the GstVideoOverlayCompositionMeta API
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Sun Mar 2 11:42:37 PST 2014
https://bugzilla.gnome.org/show_bug.cgi?id=721950
GStreamer | gst-plugins-bad | git
Sebastian Dröge (slomo) <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #268076|accepted-commit_now |needs-work
status| |
--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-03-02 20:04:41 UTC ---
Review of attachment 268076:
--> (https://bugzilla.gnome.org/review?bug=721950&attachment=268076)
Which GstPad fix?
But the patch is almost good to be merged, some minor comments here
::: ext/assrender/gstassrender.c
@@ +185,3 @@
"Sebastian Dröge <sebastian.droege at collabora.co.uk>");
+
+ klass->sw_template_caps = gst_static_caps_get (&sw_template_caps);
There's no point in storing static caps in the class, just get them
whenever needed.
@@ +573,3 @@
+ GST_CAPS_INTERSECT_FIRST);
+ }
+
If you first unref and then append it is more efficient as the simple caps
can then just be taken directly instead of copying them
@@ +611,3 @@
+
+ /* if peer returns ANY caps, return src pad template caps */
+ caps = gst_caps_copy (gst_pad_get_pad_template_caps (srcpad));
Apply filter here
@@ +674,2 @@
+ /* if peer returns ANY caps, return sink pad template caps */
+ caps = gst_caps_copy (gst_pad_get_pad_template_caps (sinkpad));
Apply filter here
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list