[Bug 721953] pango: basetextoverlay: handle video/x-raw(ANY) if downstream supports the GstVideoOverlayCompositionMeta API

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721953
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267669|accepted-commit_now         |needs-work
             status|                            |

--- Comment #27 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-03-02 20:07:09 UTC ---
Review of attachment 267669:
 --> (https://bugzilla.gnome.org/review?bug=721953&attachment=267669)

Basically same comments as for assrender. Almost ready to be merged :)

::: ext/pango/gstbasetextoverlay.c
@@ +394,3 @@
   klass->get_text = gst_base_text_overlay_get_text;

+  klass->sw_template_caps = gst_static_caps_get (&sw_template_caps);

No need to store this in the class, just get the caps whenever needed

@@ +1149,3 @@
+
+    gst_caps_append (new_caps, filtered_caps);
+    gst_caps_unref (simple_caps);

If you first unref and then append it is more efficient as the simple caps
can then just be taken directly instead of copying them

@@ +1188,3 @@
+
+      /* if peer returns ANY caps, return src pad template caps */
+      caps = gst_caps_copy (gst_pad_get_pad_template_caps (srcpad));

Apply filter here

@@ +1251,3 @@
+
+      /* if peer returns ANY caps, return sink pad template caps */
+      caps = gst_caps_copy (gst_pad_get_pad_template_caps (sinkpad));

Apply filter here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.