[Bug 740236] New interleave2 based on GstAggregator and create GstAudioAggregator from audiomixer

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740236
  GStreamer | gst-plugins-bad | git

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291387|none                        |reviewed
             status|                            |

--- Comment #26 from Thibault Saunier <tsaunier at gnome.org> 2014-11-25 20:53:02 UTC ---
Review of attachment 291387:
 --> (https://bugzilla.gnome.org/review?bug=740236&attachment=291387)

Looks good, just minor comments.

::: gst-libs/gst/base/gstaggregator.c
@@ +1024,3 @@

+  GST_OBJECT_LOCK (self);
+  data.min += self->priv->subclass_min_latency;

min latency can not be CLOCK_TIME_NONE then? What if subclass does not know but
knows the max?

@@ +1881,3 @@
+
+/**
+ * gst_aggregator_set_latency:

Please add that to section.txt too.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.