[Bug 740236] New interleave2 based on GstAggregator and create GstAudioAggregator from audiomixer

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740236
  GStreamer | gst-plugins-bad | git

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291388|none                        |rejected
             status|                            |

--- Comment #27 from Thibault Saunier <tsaunier at gnome.org> 2014-11-25 21:08:01 UTC ---
Review of attachment 291388:
 --> (https://bugzilla.gnome.org/review?bug=740236&attachment=291388)

I do not understand why you would say it is a hack at all? The subclass can
have information about the fact it is EOS that baseclass does not know, and we
need to let the subclass tell us if it is the case, for example here in
videoaggregator, in the case we have output_end_time == output_start_time, we
*know* at that point that we are EOS, we have not received any EOS event on the
pad but we do not care at that point.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.